refactor: initial adjustments#1
Merged
andreynering merged 7 commits intomainfrom Aug 29, 2025
Merged
Conversation
* Check errors where we weren't checking them * Exit with status 1 on errors
andreynering
force-pushed
the
initial-adjustments
branch
from
ad45c37 to
ddaaa78
Compare
Reasoning for this is: 1. Users can import only those they want, and the Go compiler won't compile the external library the user don't need. 2. This simplify the API and makes it follow the Go conventions better: * `ai.NewOpenAiProvider` -> `openai.New` * `ai.WithOpenAiAPIKey` -> `openai.WithAPIKey` * etc.
andreynering
force-pushed
the
initial-adjustments
branch
from
8b3ed35 to
2b1c62a
Compare
These struct types don't make sense to be part of the public API. They are only used internally to map options to the actual provider SDKs.
andreynering
force-pushed
the
initial-adjustments
branch
from
2b1c62a to
999fe4a
Compare
kujtimiihoxha
approved these changes
Aug 29, 2025
Member
Author
|
I’ll merge this to unblock further work. Still open for reviews as we can address changes on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General adjustments and fixes as I review the codebase.
I advice to review commits individually.
The most relevant changes are:
refactor: move each provider into its own package
Reasoning for this is:
ai.NewOpenAiProvider->openai.Newai.WithOpenAiAPIKey->openai.WithAPIKeyrefactor: change provider options structs to be private / internal
These struct types don't make sense to be part of the public API. They are only used internally to map options to the actual provider SDKs.